fix: Clean up custom css when dashboard unmounted (#19342)

* clean up custom css when dashboard unmounted * resolve comment
apache · Apr 5, 2022 · a88fa89 · a88fa89
1 parent 634693b
commit a88fa89
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/superset-frontend/src/dashboard/containers/DashboardPage.tsx b/superset-frontend/src/dashboard/containers/DashboardPage.tsx
@@ -231,7 +231,7 @@ export const DashboardPage: FC<PageProps> = ({ idOrSlug }: PageProps) => {
   }, [dashboard_title]);
 
   useEffect(() => {
-    if (css) {
+    if (typeof css === 'string') {
       // returning will clean up custom css
       // when dashboard unmounts or changes
       return injectCustomCss(css);