fix: Reset sorting bar issue in Barchart (#19371)

* fix: Reset sorting bar issue in Barchart * improving performance * fix lint error
apache · Apr 13, 2022 · 94e06c2 · 94e06c2
1 parent 8e326af
commit 94e06c2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
@@ -434,7 +434,11 @@ function nvd3Vis(element, props) {
         chart.stacked(isBarStacked);
         if (orderBars) {
           data.forEach(d => {
-            d.values.sort((a, b) => (tryNumify(a.x) < tryNumify(b.x) ? -1 : 1));
+            const newValues = [...d.values]; // need to copy values to avoid redux store changed.
+            // eslint-disable-next-line no-param-reassign
+            d.values = newValues.sort((a, b) =>
+              tryNumify(a.x) < tryNumify(b.x) ? -1 : 1,
+            );
           });
         }
         if (!reduceXTicks) {