Skip to content

Commit

Permalink
Revert "Binding key Q to the running the query in explore view" (#713)
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch authored Jul 1, 2016
1 parent 1998314 commit 8135c24
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
12 changes: 0 additions & 12 deletions caravel/assets/javascripts/explore.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ var jQuery = window.jQuery = $;
var px = require('./modules/caravel.js');
var showModal = require('./modules/utils.js').showModal;

var isQueryRunning = false;

require('jquery-ui');
$.widget.bridge('uitooltip', $.ui.tooltip); // Shutting down jq-ui tooltips
require('bootstrap');
Expand Down Expand Up @@ -58,10 +56,6 @@ function prepForm() {
}

function query(force, pushState) {
if (isQueryRunning) {
return;
}
isQueryRunning = true;
if (force === undefined) {
force = false;
}
Expand All @@ -77,7 +71,6 @@ function query(force, pushState) {
history.pushState({}, document.title, slice.querystring());
}
slice.render(force);
isQueryRunning = false;
}

function initExploreView() {
Expand Down Expand Up @@ -489,9 +482,4 @@ $(document).ready(function () {

$('div.toggle').addClass('pull-right');
slice.bindResizeToWindowResize();
document.addEventListener("keyup", function (k) {
if (k.key === 'q' || k.key === 'Q') {
query(true);
}
});
});
6 changes: 0 additions & 6 deletions docs/faq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,3 @@ framework, in the meantime, we've tagged a few pull requests as
visualizations.

https://github.com/airbnb/caravel/issues?q=label%3Aexample+is%3Aclosed


Is there shortcut for the Query button
--------------------------------------

Yes, `q` or `Q` will do it.

0 comments on commit 8135c24

Please sign in to comment.