Skip to content

Commit

Permalink
chore(Dashboard): Implement dedicated message for missing dataset (#1…
Browse files Browse the repository at this point in the history
…6959)

* Implement dedicated message

* Clean up
  • Loading branch information
geido authored Oct 8, 2021
1 parent 9e980b6 commit 42efcdf
Show file tree
Hide file tree
Showing 3 changed files with 94 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import React from 'react';
import { render, screen } from 'spec/helpers/testing-library';
import DatasetNotFoundErrorMessage from './DatasetNotFoundErrorMessage';
import { ErrorLevel, ErrorSource, ErrorTypeEnum } from './types';

const mockedProps = {
error: {
error_type: ErrorTypeEnum.FAILED_FETCHING_DATASOURCE_INFO_ERROR,
level: 'error' as ErrorLevel,
message: 'The dataset associated with this chart no longer exists',
extra: {},
},
source: 'dashboard' as ErrorSource,
};

test('should render', () => {
const { container } = render(
<DatasetNotFoundErrorMessage {...mockedProps} />,
);
expect(container).toBeInTheDocument();
});

test('should render the default title', () => {
render(<DatasetNotFoundErrorMessage {...mockedProps} />);
expect(screen.getByText('Missing dataset')).toBeInTheDocument();
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { t } from '@superset-ui/core';

import { ErrorMessageComponentProps } from './types';
import ErrorAlert from './ErrorAlert';

function DatasetNotFoundErrorMessage({
error,
source = 'dashboard',
subtitle,
}: ErrorMessageComponentProps) {
const { level, message } = error;

return (
<ErrorAlert
title={t('Missing dataset')}
subtitle={subtitle}
level={level}
source={source}
copyText={message}
body={null}
/>
);
}

export default DatasetNotFoundErrorMessage;
5 changes: 5 additions & 0 deletions superset-frontend/src/setup/setupErrorMessages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { ErrorTypeEnum } from 'src/components/ErrorMessage/types';
import TimeoutErrorMessage from 'src/components/ErrorMessage/TimeoutErrorMessage';
import DatabaseErrorMessage from 'src/components/ErrorMessage/DatabaseErrorMessage';
import ParameterErrorMessage from 'src/components/ErrorMessage/ParameterErrorMessage';
import DatasetNotFoundErrorMessage from 'src/components/ErrorMessage/DatasetNotFoundErrorMessage';

import setupErrorMessagesExtra from './setupErrorMessagesExtra';

Expand Down Expand Up @@ -139,5 +140,9 @@ export default function setupErrorMessages() {
ErrorTypeEnum.CONNECTION_DATABASE_PERMISSIONS_ERROR,
DatabaseErrorMessage,
);
errorMessageComponentRegistry.registerValue(
ErrorTypeEnum.FAILED_FETCHING_DATASOURCE_INFO_ERROR,
DatasetNotFoundErrorMessage,
);
setupErrorMessagesExtra();
}

0 comments on commit 42efcdf

Please sign in to comment.