review comments

apache · May 4, 2022 · 2fd9355 · 2fd9355
1 parent a8c87e4
commit 2fd9355
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.tsx b/superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.tsx
@@ -50,7 +50,7 @@ const ControlPopover: React.FC<PopoverProps> = ({
   const triggerElementRef = useRef<HTMLElement>();
 
   const [visible, setVisible] = useState(
-    !!(visibleProp || props.defaultVisible),
+    visibleProp === undefined ? props.defaultVisible : visibleProp,
   );
   const [placement, setPlacement] = React.useState<TooltipPlacement>('right');
 
@@ -97,13 +97,13 @@ const ControlPopover: React.FC<PopoverProps> = ({
   );
 
   const handleOnVisibleChange = useCallback(
-    (visible: boolean) => {
+    (visible: boolean | undefined) => {
       if (visible === undefined) {
         changeContainerScrollStatus(visible);
       }
 
       setVisible(!!visible);
-      props.onVisibleChange?.(visible);
+      props.onVisibleChange?.(!!visible);
     },
     [props, changeContainerScrollStatus],
   );
@@ -119,7 +119,9 @@ const ControlPopover: React.FC<PopoverProps> = ({
   );
 
   useEffect(() => {
-    setVisible(!!visibleProp);
+    if (visibleProp !== undefined) {
+      setVisible(!!visibleProp);
+    }
   }, [visibleProp]);
 
   useEffect(() => {