Skip to content

Commit

Permalink
chore: remove unused codes for samples (#20272)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhaoyongjie authored Jun 7, 2022
1 parent b110581 commit 27c3ef1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
1 change: 1 addition & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ assists people when migrating to a new version.
- [19046](https://github.com/apache/superset/pull/19046): Enables the drag and drop interface in Explore control panel by default. Flips `ENABLE_EXPLORE_DRAG_AND_DROP` and `ENABLE_DND_WITH_CLICK_UX` feature flags to `True`.
- [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interim logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted.
- [19570](https://github.com/apache/superset/pull/19570): makes [sqloxide](https://pypi.org/project/sqloxide/) optional so the SIP-68 migration can be run on aarch64. If the migration is taking too long installing sqloxide manually should improve the performance.
- [20170](https://github.com/apache/superset/pull/20170): Introduced a new endpoint for getting datasets samples.

### Breaking Changes

Expand Down
10 changes: 1 addition & 9 deletions superset-frontend/src/explore/exploreUtils/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
getChartBuildQueryRegistry,
getChartMetadataRegistry,
} from '@superset-ui/core';
import { omit } from 'lodash';
import { availableDomains } from 'src/utils/hostNamesConfig';
import { safeStringify } from 'src/utils/safeStringify';
import { URL_PARAMS } from 'src/constants';
Expand Down Expand Up @@ -216,7 +215,7 @@ export const buildV1ChartDataPayload = ({
...baseQueryObject,
},
]));
const payload = buildQuery(
return buildQuery(
{
...formData,
force,
Expand All @@ -230,13 +229,6 @@ export const buildV1ChartDataPayload = ({
},
},
);
if (resultType === 'samples') {
// remove row limit and offset to fall back to defaults
payload.queries = payload.queries.map(query =>
omit(query, ['row_limit', 'row_offset']),
);
}
return payload;
};

export const getLegacyEndpointType = ({ resultType, resultFormat }) =>
Expand Down

0 comments on commit 27c3ef1

Please sign in to comment.