Skip to content

Commit

Permalink
fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBL…
Browse files Browse the repository at this point in the history
…OB as opposed to BLOB for MySQL (#20385)

* fix(migration): Ensure key_value LargeBinary is encoded as a MEDIUMBLOB as opposed to BLOB for MySQL

* Update 2022-06-14_15-28_e09b4ae78457_resize_key_value_blob.py

Co-authored-by: John Bodley <[email protected]>
(cherry picked from commit f5cb23e)
  • Loading branch information
john-bodley authored and michael-s-molina committed Jun 28, 2022
1 parent 40a9257 commit 23061d6
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 1 deletion.
2 changes: 1 addition & 1 deletion superset/key_value/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class KeyValueEntry(Model, AuditMixinNullable, ImportExportMixin):
__tablename__ = "key_value"
id = Column(Integer, primary_key=True)
resource = Column(String(32), nullable=False)
value = Column(LargeBinary(), nullable=False)
value = Column(LargeBinary(length=2**24 - 1), nullable=False)
created_on = Column(DateTime, nullable=True)
created_by_fk = Column(Integer, ForeignKey("ab_user.id"), nullable=True)
changed_on = Column(DateTime, nullable=True)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""Resize key_value blob
Revision ID: e09b4ae78457
Revises: e786798587de
Create Date: 2022-06-14 15:28:42.746349
"""

# revision identifiers, used by Alembic.
revision = "e09b4ae78457"
down_revision = "e786798587de"

import sqlalchemy as sa
from alembic import op


def upgrade():
with op.batch_alter_table("key_value", schema=None) as batch_op:
batch_op.alter_column(
"value",
existing_nullable=False,
existing_type=sa.LargeBinary(),
type_=sa.LargeBinary(length=2**24 - 1),
)


def downgrade():
with op.batch_alter_table("key_value", schema=None) as batch_op:
batch_op.alter_column(
"value",
existing_nullable=False,
existing_type=sa.LargeBinary(length=2**24 - 1),
type_=sa.LargeBinary(),
)

0 comments on commit 23061d6

Please sign in to comment.