return early if database is None

apache · Feb 25, 2022 · 0b0b7f9 · 0b0b7f9
1 parent ec145b8
commit 0b0b7f9
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/superset/migrations/versions/b8d3a24d9131_new_dataset_models.py b/superset/migrations/versions/b8d3a24d9131_new_dataset_models.py
@@ -323,12 +323,10 @@ def after_insert(target: SqlaTable) -> None:  # pylint: disable=too-many-locals
         target.database
         or session.query(Database).filter_by(id=target.database_id).first()
     )
-    engine: Optional[Engine] = None
-    if database:
-        engine = database.get_sqla_engine(schema=target.schema)
-    conditional_quote = (
-        engine.dialect.identifier_preparer.quote if engine else lambda x: x
-    )
+    if not database:
+        return
+    engine = database.get_sqla_engine(schema=target.schema)
+    conditional_quote = engine.dialect.identifier_preparer.quote
 
     # create columns
     columns = []