Fix broken scope

apache · Oct 15, 2021 · 06bf6eb · 06bf6eb
1 parent 5f83b7c
commit 06bf6eb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/...ontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx b/...ontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
@@ -103,13 +103,7 @@ const FilterControls: FC<FilterControlsProps> = ({
         ))}
       {filtersInScope.map(filter => {
         const index = filterValues.findIndex(f => f.id === filter.id);
-        return (
-          <OutPortal
-            key={`filters-inscope-${index}`}
-            node={portalNodes[index]}
-            inView
-          />
-        );
+        return <OutPortal node={portalNodes[index]} inView />;
       })}
       {showCollapsePanel && (
         <Collapse
@@ -147,13 +141,7 @@ const FilterControls: FC<FilterControlsProps> = ({
           >
             {filtersOutOfScope.map(filter => {
               const index = cascadeFilters.findIndex(f => f.id === filter.id);
-              return (
-                <OutPortal
-                  key={`filters-outofscope-${index}`}
-                  node={portalNodes[index]}
-                  inView
-                />
-              );
+              return <OutPortal node={portalNodes[index]} inView />;
             })}
           </Collapse.Panel>
         </Collapse>

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/state.ts b/superset-frontend/src/dashboard/components/nativeFilters/state.ts
@@ -90,7 +90,6 @@ function useIsFilterInScope() {
   // Chart is visible if it's placed in an active tab tree or if it's not attached to any tab.
   // Chart is in an active tab tree if all of it's ancestors of type TAB are active
   return (filter: CascadeFilter) =>
-    filter.chartsInScope === undefined ||
     filter.chartsInScope?.some((chartId: number) => {
       const tabParents = selectChartTabParents(chartId);
       return (