STORM-4085 - Ensure that DownloadOrUpdate exception is caught #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agresch
approved these changes
Oct 8, 2024
reiabreu
approved these changes
Oct 8, 2024
rzo1
changed the title
rzo1
approved these changes
Oct 9, 2024
|
Thanks for the PR @paxadax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Issue
The AsyncLocalizer class contains a scheduler that continuously performs downloadOrUpdate operations on blobs. Currently, if an exception occurs during this update process, the exception is not properly handled, causing the thread to terminate.
As a result, workers are unable to update blobs because the threads have been killed. The only way to recover from this is by restarting the supervisor.
This fix ensures that exceptions are properly handled, preventing workers from getting stuck while updating blobs.
How was the change tested
After a few leadership changes, the worker threads for updating blobs are killed. On my tests, I forced leadership changes and ensure that the threads are not being killed due to exceptions.