[SPARK-51085][SQL] Restore SQLContext Companion #49964
Closed
+59
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicennial
approved these changes
Feb 17, 2025
asfgit
pushed a commit
that referenced
this pull request
Feb 17, 2025
### What changes were proposed in this pull request? The companion object for SQLContext was accidentally dropped when we swapped the interface and the implementation. This PR restores the companion. ### Why are the changes needed? The SQLContext Companion is part of the ### Does this PR introduce _any_ user-facing change? No. Well it mitigates a potentially user facing change. ### How was this patch tested? I added a test to `SparkSessionBuilderImplementationBindingSuite`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49964 from hvanhovell/SPARK-51085. Authored-by: Herman van Hovell <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit aeea738) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The companion object for SQLContext was accidentally dropped when we swapped the interface and the implementation. This PR restores the companion.
Why are the changes needed?
The SQLContext Companion is part of the
Does this PR introduce any user-facing change?
No. Well it mitigates a potentially user facing change.
How was this patch tested?
I added a test to
SparkSessionBuilderImplementationBindingSuite.Was this patch authored or co-authored using generative AI tooling?
No.