[SPARK-51176][PYTHON][CONNECT] Meet consistency for unexpected errors PySpark Connect <> Classic #49926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PySpark Connect <> Classic
|
LGTM |
HyukjinKwon
approved these changes
Feb 18, 2025
|
Merged to master and brnach-4.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 18, 2025
… PySpark Connect <> Classic ### What changes were proposed in this pull request? This PR proposes to add `UnknownException` for Spark Connect Python client to meet consistency for unexpected errors PySpark Connect <> Classic ### Why are the changes needed? To meet consistency between PySpark Connect and Classic. Also, `UnknownErrors` might more clearer than `SparkConnectGrpcException` for unexpected errors to end users. ### Does this PR introduce _any_ user-facing change? No API changes, but the user-facing error improvement ### How was this patch tested? The existing CI should pass ### Was this patch authored or co-authored using generative AI tooling? No Closes #49926 from itholic/unexpected_error. Lead-authored-by: Haejoon Lee <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit dc3fb50) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add
UnknownExceptionfor Spark Connect Python client to meet consistency for unexpected errors PySpark Connect <> ClassicWhy are the changes needed?
To meet consistency between PySpark Connect and Classic. Also,
UnknownErrorsmight more clearer thanSparkConnectGrpcExceptionfor unexpected errors to end users.Does this PR introduce any user-facing change?
No API changes, but the user-facing error improvement
How was this patch tested?
The existing CI should pass
Was this patch authored or co-authored using generative AI tooling?
No