[SPARK-50579][SQL] Fix truncatedString
#49187
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to respect the
maxFields
argument ofSparkStringUtils.truncatedString
in all cases independently from the size of the another argumentseq
. If size ofseq
is grater or equal tomaxFields
, output exactmaxFields
elements ofseq
.Also, if the number of printed elements is zero, don't print the redundant comma
,
like[, ... 100 more fields]
, and don't overflow whenmaxFields
isInt.MinValue
.Why are the changes needed?
To make output consistent for the same
maxFields
. For example, ifmaxFields
is 2:but for more elements in the input sequence, it prints only one element:
though the expected output is "[1, 2, ... 1 more fields]".
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By existing tests from
UtilSuite
that are moved toStringUtilsSuite
and additional checks:Was this patch authored or co-authored using generative AI tooling?
No.