[SPARK-50360][SS][FOLLOWUP][MINOR] Make readVersion lazy value #49091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WweiL
reviewed
Dec 13, 2024
...core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala
Outdated
Show resolved
Hide resolved
WweiL
approved these changes
Dec 13, 2024
tedyu
changed the title
tedyu
changed the title
|
@HeartSaVioR |
HeartSaVioR
reviewed
Dec 14, 2024
...core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreChangelog.scala
Outdated
Show resolved
Hide resolved
|
I think it should be renamed as |
tedyu
changed the title
|
@HeartSaVioR |
HeartSaVioR
changed the title
|
The failure only happened with TPC, which isn't relevant. |
|
Thanks! Merging to master. |
|
Forgot to call out +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is followup to #48880
readVersionis made alazyvalue.After
inputis closed, its value is not changed tonullbecauseinputis only used byreadVersion.Why are the changes needed?
StateStoreChangelogReaderFactoryis able to produce more than one reader.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test suite.
Was this patch authored or co-authored using generative AI tooling?
No