Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50493][BUILD] Upgrade kubernetes-client to 7.0.0 #49066

Closed
wants to merge 23 commits into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Dec 5, 2024

What changes were proposed in this pull request?

The pr aims to upgrade kubernetes-client from 6.13.2 to 7.0.0.

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Dec 5, 2024
@@ -37,7 +37,7 @@
<dependencies>
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>volcano-model-v1beta1</artifactId>
<artifactId>volcano-model</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@@ -227,7 +235,7 @@ netty-transport-native-kqueue/4.1.115.Final/osx-x86_64/netty-transport-native-kq
netty-transport-native-unix-common/4.1.115.Final//netty-transport-native-unix-common-4.1.115.Final.jar
netty-transport/4.1.115.Final//netty-transport-4.1.115.Final.jar
objenesis/3.3//objenesis-3.3.jar
okhttp/3.12.12//okhttp-3.12.12.jar
okhttp/4.12.0//okhttp-4.12.0.jar
Copy link
Member

@pan3793 pan3793 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The K8s client "Switch default HTTP client from OkHttp to Vert.x" in fabric8io/kubernetes-client#6470

instead of upgrading OkHttp4 and pulling Kotlin runtime deps, maybe following the upstream to switch to Vert.x is a better option?

Copy link
Contributor Author

@panbingkun panbingkun Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fine to me.
From 6.x to 7.x, we need to make some changes first, let's run GA first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 for @pan3793 's comment.

kotlin-stdlib-common/1.8.21//kotlin-stdlib-common-1.8.21.jar
kotlin-stdlib-jdk7/1.8.21//kotlin-stdlib-jdk7-1.8.21.jar
kotlin-stdlib-jdk8/1.8.21//kotlin-stdlib-jdk8-1.8.21.jar
kotlin-stdlib/1.8.21//kotlin-stdlib-1.8.21.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is this correct?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, K8s CA seems to fail still for some reason. (Of course, that's the reason of Draft).

@panbingkun
Copy link
Contributor Author

For the record, K8s CA seems to fail still for some reason. (Of course, that's the reason of Draft).

Well, yes, I'm working on it and it will take some time.

@panbingkun
Copy link
Contributor Author

I have already created a new PR #49159 for this feature (switch default HttpClient implementation from OkHttp to Vert.x).
I will close this PR. cc @dongjoon-hyun @pan3793

@panbingkun panbingkun closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to use okhttp4 due to a bug on IPV6 based cluster
3 participants