[SPARK-50492][SS] Fix java.util.NoSuchElementException when event time column is dropped after dropDuplicatesWithinWatermark #49065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please sync your fork with OSS and rebase your PR to be on top of recent master branch? It's on top of the commit which was 3 weeks ago. GA failure looks to be related to the out of sync. |
HeartSaVioR
reviewed
Dec 5, 2024
...alyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
Outdated
Show resolved
Hide resolved
liviazhu-db
changed the title
HeartSaVioR
changed the title
|
Thanks! Merging to master/3.5. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Dec 6, 2024
…e column is dropped after dropDuplicatesWithinWatermark ### What changes were proposed in this pull request? Update `DeduplicateWithinWatermark` references to include all attributes that could be the watermarking column. ### Why are the changes needed? Fix `java.util.NoSuchElementException` due to ColumnPruning. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added unit test ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49065 from liviazhu-db/liviazhu-db/dedup-watermark-fix. Authored-by: Livia Zhu <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit 851f5f2) Signed-off-by: Jungtaek Lim <[email protected]>
|
@liviazhu-db @HeartSaVioR branch-3.5 build failed
|
|
Try fix: #49087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update
DeduplicateWithinWatermarkreferences to include all attributes that could be the watermarking column.Why are the changes needed?
Fix
java.util.NoSuchElementExceptiondue to ColumnPruning.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit test
Was this patch authored or co-authored using generative AI tooling?
No.