[SPARK-50155][INFRA] Move scala and java files to their default folders
#48691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
changed the title
scala and java files to their default folders
MaxGekk
approved these changes
Oct 29, 2024
|
+1, LGTM. Merging to master. |
|
Thank you, @panbingkun and @MaxGekk . Can we have this fix in branch-3.5, too? BTW, to @panbingkun , this seems not |
Okay, allow me to do it.
Haha, this is my first time doing something like this, and I'm not sure what |
Branch-3.5: #48700 |
MaxGekk
pushed a commit
that referenced
this pull request
Oct 30, 2024
### What changes were proposed in this pull request? The pr aims to move `scala` and `java` files to their default folders (`src/main/scala` and `src/main/java`), includes: - `ByteArrayUtils.java` from: `common/utils/src/main/scala/org/apache/spark/unsafe/array/ByteArrayUtils.java` to: `common/utils/src/main/java/org/apache/spark/unsafe/array/ByteArrayUtils.java` - `CustomDecimal.scala` from: `connector/avro/src/main/java/org/apache/spark/sql/avro/CustomDecimal.scala` to: `connector/avro/src/main/scala/org/apache/spark/sql/avro/CustomDecimal.scala` PS: The pr is backport branch-3.5, master pr is: #48691 Note: In branch-3.5, the `OrcCompressionCodec.java` file does not exist, so there is no need to move it. ### Why are the changes needed? Move `scala` and `java` files to the default folder of the project to avoid `misunderstandings` for spark developers. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48700 from panbingkun/SPARK-50155_branch3.5. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to move
scalaandjavafiles to their default folders (src/main/scalaandsrc/main/java), includes:ByteArrayUtils.javafrom:
common/utils/src/main/scala/org/apache/spark/unsafe/array/ByteArrayUtils.javato:
common/utils/src/main/java/org/apache/spark/unsafe/array/ByteArrayUtils.javaCustomDecimal.scalafrom:
connector/avro/src/main/java/org/apache/spark/sql/avro/CustomDecimal.scalato:
connector/avro/src/main/scala/org/apache/spark/sql/avro/CustomDecimal.scalaOrcCompressionCodec.javafrom:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcCompressionCodec.javato:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcCompressionCodec.javaWhy are the changes needed?
Move
scalaandjavafiles to the default folder of the project to avoidmisunderstandingsfor spark developers.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.