Revert "[SPARK-49909][SQL] Fix the pretty name of some expressions" #48530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52538f0.
HyukjinKwon
approved these changes
Oct 18, 2024
zhengruifeng
approved these changes
Oct 18, 2024
dongjoon-hyun
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
+1, LGTM. Thank you for reverting before Apache Spark 3.4.4, @panbingkun .
|
cc @MaxGekk |
|
Thanks all! |
MaxGekk
reviewed
Oct 18, 2024
Okay, let me add something for it. |
Done. |
MaxGekk
approved these changes
Oct 18, 2024
|
+1, LGTM. Merging to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? The pr aims to revert apache#48385. This reverts commit 52538f0. ### Why are the changes needed? When upgrading spark from `an old version` to `the latest version`, some end-users may rely on the `original schema` (`although it may not be correct`), which can make the `upgrade` very difficult. so, let's first restore it to its original state. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48530 from panbingkun/SPARK-49909_revert. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to revert #48385.
This reverts commit 52538f0.
Why are the changes needed?
When upgrading spark from
an old versiontothe latest version, some end-users may rely on theoriginal schema(although it may not be correct), which can make theupgradevery difficult. so, let's first restore it to its original state.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA
Was this patch authored or co-authored using generative AI tooling?
No.