[SPARK-50014][INFRA] Use grpcio* 1.67.0 in Python 3.13 image
#48522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this infra PR for Python 3.13 support, @huaxingao ? The image build succeeded already and I manually validate. And, the CI result is irrelevant to this PR because Python 3.13 is only used in Daily CI seperately. |
huaxingao
approved these changes
Oct 17, 2024
|
Thank you, @huaxingao ! |
|
Let me merge this because Today's Python 3.13 test will start soon. |
|
For the record, |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? This PR aims to use `grpcio` and `grpcio-status` `1.67.0` for Python 3.13 tests in order to reveal the remaining test failures after installing the official `grpcio` in Python 3.13 environment. ### Why are the changes needed? `grpcio` added Python 3.13 support since 1.66.2. - https://pypi.org/project/grpcio/1.67.0/ - https://pypi.org/project/grpcio/1.66.2/ ### Does this PR introduce _any_ user-facing change? No, this is an infra change for test coverage. Currently, `pyspark-connect` module test fails due to the missing required package, `grpc`, like the following. - https://github.com/apache/spark/actions/runs/11372942311/job/31638495254 ``` ModuleNotFoundError: No module named 'grpc' ``` ### How was this patch tested? Manual check the generated image of this PR builder. ``` $ docker run -it --rm ghcr.io/dongjoon-hyun/apache-spark-ci-image:master-11389776259 python3.13 -m pip list | grep grpcio grpcio 1.67.0 grpcio-status 1.67.0 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48522 from dongjoon-hyun/SPARK-50014. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
grpcioandgrpcio-status1.67.0for Python 3.13 tests in order to reveal the remaining test failures after installing the officialgrpcioin Python 3.13 environment.Why are the changes needed?
grpcioadded Python 3.13 support since 1.66.2.Does this PR introduce any user-facing change?
No, this is an infra change for test coverage. Currently,
pyspark-connectmodule test fails due to the missing required package,grpc, like the following.How was this patch tested?
Manual check the generated image of this PR builder.
Was this patch authored or co-authored using generative AI tooling?
No.