-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-49986][INFRA] Restore scipy
installation in dockerfile
#48489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @dongjoon-hyun and @panbingkun |
zhengruifeng
commented
Oct 16, 2024
@@ -152,6 +152,6 @@ RUN python3.13 -m pip install lxml numpy>=2.1 && \ | |||
python3.13 -m pip cache purge | |||
|
|||
# Remove unused installation packages to free up disk space | |||
RUN apt-get remove --purge -y 'gfortran-11' 'humanity-icon-theme' 'nodejs-doc' || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove || true
to avoid silent failure
xinrong-meng
approved these changes
Oct 16, 2024
Just wanted to add that dev/create-release/spark-rm/Dockerfile also has gfortran installed. |
LGTM |
panbingkun
approved these changes
Oct 16, 2024
HyukjinKwon
approved these changes
Oct 17, 2024
Merged to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? Restore `scipy` installation in dockerfile ### Why are the changes needed? https://docs.scipy.org/doc/scipy-1.13.1/building/index.html#system-level-dependencies > If you want to use the system Python and pip, you will need: C, C++, and Fortran compilers (typically gcc, g++, and gfortran). ... `scipy` actually depends on `gfortran`, but `apt-get remove --purge -y 'gfortran-11'` broke this dependency. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? manually check with the first commit apache@5be0dfa: move `apt-get remove --purge -y 'gfortran-11'` ahead of `scipy` installation, then the installation fails with ``` apache#18 394.3 Collecting scipy apache#18 394.4 Downloading scipy-1.13.1.tar.gz (57.2 MB) apache#18 395.2 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 57.2/57.2 MB 76.7 MB/s eta 0:00:00 apache#18 401.3 Installing build dependencies: started apache#18 410.5 Installing build dependencies: finished with status 'done' apache#18 410.5 Getting requirements to build wheel: started apache#18 410.7 Getting requirements to build wheel: finished with status 'done' apache#18 410.7 Installing backend dependencies: started apache#18 411.8 Installing backend dependencies: finished with status 'done' apache#18 411.8 Preparing metadata (pyproject.toml): started apache#18 414.9 Preparing metadata (pyproject.toml): finished with status 'error' apache#18 414.9 error: subprocess-exited-with-error apache#18 414.9 apache#18 414.9 × Preparing metadata (pyproject.toml) did not run successfully. apache#18 414.9 │ exit code: 1 apache#18 414.9 ╰─> [42 lines of output] apache#18 414.9 + meson setup /tmp/pip-install-y77ar9d0/scipy_1e543e0816ed4b26984415533ae9079d /tmp/pip-install-y77ar9d0/scipy_1e543e0816ed4b26984415533ae9079d/.mesonpy-xqfvs4ek -Dbuildtype=release -Db_ndebug=if-release -Db_vscrt=md --native-file=/tmp/pip-install-y77ar9d0/scipy_1e543e0816ed4b26984415533ae9079d/.mesonpy-xqfvs4ek/meson-python-native-file.ini apache#18 414.9 The Meson build system apache#18 414.9 Version: 1.5.2 apache#18 414.9 Source dir: /tmp/pip-install-y77ar9d0/scipy_1e543e0816ed4b26984415533ae9079d apache#18 414.9 Build dir: /tmp/pip-install-y77ar9d0/scipy_1e543e0816ed4b26984415533ae9079d/.mesonpy-xqfvs4ek apache#18 414.9 Build type: native build apache#18 414.9 Project name: scipy apache#18 414.9 Project version: 1.13.1 apache#18 414.9 C compiler for the host machine: cc (gcc 11.4.0 "cc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0") apache#18 414.9 C linker for the host machine: cc ld.bfd 2.38 apache#18 414.9 C++ compiler for the host machine: c++ (gcc 11.4.0 "c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0") apache#18 414.9 C++ linker for the host machine: c++ ld.bfd 2.38 apache#18 414.9 Cython compiler for the host machine: cython (cython 3.0.11) apache#18 414.9 Host machine cpu family: x86_64 apache#18 414.9 Host machine cpu: x86_64 apache#18 414.9 Program python found: YES (/usr/local/bin/pypy3) apache#18 414.9 Run-time dependency python found: YES 3.9 apache#18 414.9 Program cython found: YES (/tmp/pip-build-env-v_vnvt3h/overlay/bin/cython) apache#18 414.9 Compiler for C supports arguments -Wno-unused-but-set-variable: YES apache#18 414.9 Compiler for C supports arguments -Wno-unused-function: YES apache#18 414.9 Compiler for C supports arguments -Wno-conversion: YES apache#18 414.9 Compiler for C supports arguments -Wno-misleading-indentation: YES apache#18 414.9 Library m found: YES apache#18 414.9 apache#18 414.9 ../meson.build:78:0: ERROR: Unknown compiler(s): [['gfortran'], ['flang'], ['nvfortran'], ['pgfortran'], ['ifort'], ['ifx'], ['g95']] apache#18 414.9 The following exception(s) were encountered: apache#18 414.9 Running `gfortran --version` gave "[Errno 2] No such file or directory: 'gfortran'" apache#18 414.9 Running `gfortran -V` gave "[Errno 2] No such file or directory: 'gfortran'" apache#18 414.9 Running `flang --version` gave "[Errno 2] No such file or directory: 'flang'" apache#18 414.9 Running `flang -V` gave "[Errno 2] No such file or directory: 'flang'" apache#18 414.9 Running `nvfortran --version` gave "[Errno 2] No such file or directory: 'nvfortran'" apache#18 414.9 Running `nvfortran -V` gave "[Errno 2] No such file or directory: 'nvfortran'" apache#18 414.9 Running `pgfortran --version` gave "[Errno 2] No such file or directory: 'pgfortran'" apache#18 414.9 Running `pgfortran -V` gave "[Errno 2] No such file or directory: 'pgfortran'" apache#18 414.9 Running `ifort --version` gave "[Errno 2] No such file or directory: 'ifort'" apache#18 414.9 Running `ifort -V` gave "[Errno 2] No such file or directory: 'ifort'" apache#18 414.9 Running `ifx --version` gave "[Errno 2] No such file or directory: 'ifx'" apache#18 414.9 Running `ifx -V` gave "[Errno 2] No such file or directory: 'ifx'" apache#18 414.9 Running `g95 --version` gave "[Errno 2] No such file or directory: 'g95'" apache#18 414.9 Running `g95 -V` gave "[Errno 2] No such file or directory: 'g95'" apache#18 414.9 apache#18 414.9 A full log can be found at /tmp/pip-install-y77ar9d0/scipy_1e543e0816ed4b26984[4155](https://github.com/zhengruifeng/spark/actions/runs/11357130578/job/31589506939#step:7:4161)33ae9079d/.mesonpy-xqfvs4ek/meson-logs/meson-log.txt apache#18 414.9 [end of output] ``` see https://github.com/zhengruifeng/spark/actions/runs/11357130578/job/31589506939 ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#48489 from zhengruifeng/infra_scipy. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Restore
scipy
installation in dockerfileWhy are the changes needed?
https://docs.scipy.org/doc/scipy-1.13.1/building/index.html#system-level-dependencies
scipy
actually depends ongfortran
, butapt-get remove --purge -y 'gfortran-11'
broke this dependency.Does this PR introduce any user-facing change?
no
How was this patch tested?
manually check with the first commit 5be0dfa:
move
apt-get remove --purge -y 'gfortran-11'
ahead ofscipy
installation, then the installation fails withsee https://github.com/zhengruifeng/spark/actions/runs/11357130578/job/31589506939
Was this patch authored or co-authored using generative AI tooling?
no