[SPARK-49909][SQL][3.5] Fix the pretty name of some expressions #48393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Oct 9, 2024
|
cc @MaxGekk |
|
+1, LGTM. Merging to 3.5. |
MaxGekk
pushed a commit
that referenced
this pull request
Oct 9, 2024
### What changes were proposed in this pull request? The pr aims to fix the `pretty name` of some `expressions`, includes: `random`, `to_varchar`, `current_database`, `curdate`, `dateadd` and `array_agg`. (PS: The pr is backport branch-3.5, master pr is: #48385) ### Why are the changes needed? The actual function name used does not match the displayed name, as shown below: - Before: <img width="573" alt="image" src="https://github.com/user-attachments/assets/f5785c80-f6cb-494f-a15e-9258eca688a7"> - After: <img width="570" alt="image" src="https://github.com/user-attachments/assets/792a7092-ccbf-49f4-a616-19110e5c2361"> ### Does this PR introduce _any_ user-facing change? Yes, Make the header of the data seen by the end-user from `Spark SQL` consistent with the `actual function name` used. ### How was this patch tested? - Pass GA. - Update existed UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48393 from panbingkun/branch-3.5_SPARK-49909. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
MaxGekk
pushed a commit
that referenced
this pull request
Oct 18, 2024
### What changes were proposed in this pull request? The pr aims to revert #48393. This reverts commit 4472fb2. ### Why are the changes needed? Only revert. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48531 from panbingkun/branch-3.5_SPARK-49909_revert. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to fix the
pretty nameof someexpressions, includes:random,to_varchar,current_database,curdate,dateaddandarray_agg.(PS: The pr is backport branch-3.5, master pr is: #48385)
Why are the changes needed?
The actual function name used does not match the displayed name, as shown below:
Does this PR introduce any user-facing change?
Yes, Make the header of the data seen by the end-user from
Spark SQLconsistent with theactual function nameused.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.