[SPARK-49820] [PYTHON] Change raise IOError to raise OSError
#48287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seams to be the only
|
bjornjorgensen
changed the title
IOError to OSErrorraise IOError to raise OSError
dongjoon-hyun
approved these changes
Sep 27, 2024
HyukjinKwon
approved these changes
Sep 27, 2024
|
Merged to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Change `raise IOError` to `raise OSError` ### Why are the changes needed? > OSError is the builtin error type used for exceptions that relate to the operating system. > > In Python 3.3, a variety of other exceptions, like WindowsError were aliased to OSError. These aliases remain in place for compatibility with older versions of Python, but may be removed in future versions. > > Prefer using OSError directly, as it is more idiomatic and future-proof. > [RUFF rule](https://docs.astral.sh/ruff/rules/os-error-alias/) [Python OSError](https://docs.python.org/3/library/exceptions.html#OSError) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48287 from bjornjorgensen/IOError-to--OSError. Authored-by: Bjørn Jørgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? Change `raise IOError` to `raise OSError` ### Why are the changes needed? > OSError is the builtin error type used for exceptions that relate to the operating system. > > In Python 3.3, a variety of other exceptions, like WindowsError were aliased to OSError. These aliases remain in place for compatibility with older versions of Python, but may be removed in future versions. > > Prefer using OSError directly, as it is more idiomatic and future-proof. > [RUFF rule](https://docs.astral.sh/ruff/rules/os-error-alias/) [Python OSError](https://docs.python.org/3/library/exceptions.html#OSError) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48287 from bjornjorgensen/IOError-to--OSError. Authored-by: Bjørn Jørgensen <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
raise IOErrortoraise OSErrorWhy are the changes needed?
RUFF rule
Python OSError
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA
Was this patch authored or co-authored using generative AI tooling?
No.