Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49801][FOLLOWUP][INFRA] Update pandas to 2.2.3 in pages.yml too #48278

Closed

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Sep 27, 2024

What changes were proposed in this pull request?

Fix doc build.

Why are the changes needed?

in #48269

Oh, this seems to break GitHub Action Jekyll.

https://github.com/apache/spark/actions/runs/11063509911/job/30742286270
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/sphinx/config.py", line 332, in eval_config_file
exec(code, namespace)
File "/home/runner/work/spark/spark/python/docs/source/conf.py", line 33, in
generate_supported_api(output_rst_file_path)
File "/home/runner/work/spark/spark/python/pyspark/pandas/supported_api_gen.py", line 102, in generate_supported_api
_check_pandas_version()
File "/home/runner/work/spark/spark/python/pyspark/pandas/supported_api_gen.py", line 116, in _check_pandas_version
raise ImportError(msg)
ImportError: Warning: pandas 2.2.3 is required; your version is 2.2.2"

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label Sep 27, 2024
@bjornjorgensen
Copy link
Contributor Author

Followup to #48269
@yaooqinn @dongjoon-hyun

@bjornjorgensen
Copy link
Contributor Author

@yaooqinn should I call it "[FOLLOWUP][SPARK-49801][PYTHON][PS][BUILD] Update pandas to 2.2.3" ?

@bjornjorgensen bjornjorgensen changed the title [WIP] fix pandas upgrade 2.2.3 [SPARK-49801][FOLLOWUP][PYTHON][PS][BUILD] Update pandas to 2.2.3 Sep 27, 2024
@yaooqinn
Copy link
Member

The PR title LGTM

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-49801][FOLLOWUP][PYTHON][PS][BUILD] Update pandas to 2.2.3 [SPARK-49801][FOLLOWUP][INFRA] Update pandas to 2.2.3 in pages.yml too Sep 27, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you.

To @bjornjorgensen , please don't reuse the original PR title in the followup. The PR title should describe what this PR aims to do.

@bjornjorgensen bjornjorgensen deleted the fix-pandas-2.2.3 branch September 27, 2024 17:44
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
…` too

### What changes were proposed in this pull request?
Fix doc build.

### Why are the changes needed?
in apache#48269

> Oh, this seems to break GitHub Action Jekyll.

https://github.com/apache/spark/actions/runs/11063509911/job/30742286270
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/sphinx/config.py", line 332, in eval_config_file
    exec(code, namespace)
  File "/home/runner/work/spark/spark/python/docs/source/conf.py", line 33, in <module>
    generate_supported_api(output_rst_file_path)
  File "/home/runner/work/spark/spark/python/pyspark/pandas/supported_api_gen.py", line 102, in generate_supported_api
    _check_pandas_version()
  File "/home/runner/work/spark/spark/python/pyspark/pandas/supported_api_gen.py", line 116, in _check_pandas_version
    raise ImportError(msg)
ImportError: Warning: pandas 2.2.3 is required; your version is 2.2.2"

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#48278 from bjornjorgensen/fix-pandas-2.2.3.

Authored-by: Bjørn Jørgensen <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
…` too

### What changes were proposed in this pull request?
Fix doc build.

### Why are the changes needed?
in apache#48269

> Oh, this seems to break GitHub Action Jekyll.

https://github.com/apache/spark/actions/runs/11063509911/job/30742286270
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/sphinx/config.py", line 332, in eval_config_file
    exec(code, namespace)
  File "/home/runner/work/spark/spark/python/docs/source/conf.py", line 33, in <module>
    generate_supported_api(output_rst_file_path)
  File "/home/runner/work/spark/spark/python/pyspark/pandas/supported_api_gen.py", line 102, in generate_supported_api
    _check_pandas_version()
  File "/home/runner/work/spark/spark/python/pyspark/pandas/supported_api_gen.py", line 116, in _check_pandas_version
    raise ImportError(msg)
ImportError: Warning: pandas 2.2.3 is required; your version is 2.2.2"

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#48278 from bjornjorgensen/fix-pandas-2.2.3.

Authored-by: Bjørn Jørgensen <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants