Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48280][SQL] Improve collation testing surface area using expression walking #46801
[SPARK-48280][SQL] Improve collation testing surface area using expression walking #46801
Changes from 12 commits
3be0b6a
d630120
357334e
8a95bed
56532d4
af1268e
716e778
f5012ec
73be32b
394f85e
698fbcf
2c47eaf
ba680db
2f3fc4c
e4ea17d
263c141
29bb400
55f84da
ba90ca5
7017d80
497baa5
4e7b611
61bd63f
8cdb7ad
776dcba
ced5500
2c98c8d
9446fd1
8fa75ce
9902b05
a789400
e75ff5c
001f91d
9082b5e
10a358b
9da174d
6729bc6
57d11c8
bfbc9dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to organize this a bit better. I think that in future this logic may become more complex (e.g. we don't want to just pass 1 and "dummy_string". Instead we will try with different string shapes + special rules for integers (-1, 0, 1, strlen, strlen + 1...).
Again, my recommendation is to add new class for expression walker and define this logic as methods of that class.