Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45148][BUILD] Upgrade scalatest related dependencies to the 3.2.17 series #42906

Closed
wants to merge 4 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Sep 13, 2023

What changes were proposed in this pull request?

This pr aims upgrade scalatest related test dependencies to 3.2.17:

  • scalatest: upgrade scalatest to 3.2.17
  • scalatestplus
    • scalacheck: upgrade to scalacheck-1-17 3.2.17.0
    • mockito: upgrade to mockito-4-11 to 3.2.17.0
    • selenium: uprade to selenium-4-12 to 3.2.17.0 and selenium-java to 4.12.1, htmlunit-driver to 4.12.0, byte-buddy and byte-buddy-agent to 1.14.5

Why are the changes needed?

The release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual test:
    • ChromeUISeleniumSuite
    • RocksDBBackendChromeUIHistoryServerSuite
build/sbt -Dguava.version=32.1.2-jre -Dspark.test.webdriver.chrome.driver=/Users/yangjie01/Tools/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.ui.ChromeUISeleniumSuite"

build/sbt -Dguava.version=32.1.2-jre -Dspark.test.webdriver.chrome.driver=/Users/yangjie01/Tools/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.deploy.history.RocksDBBackendChromeUIHistoryServerSuite"
[info] ChromeUISeleniumSuite:
[info] - SPARK-31534: text for tooltip should be escaped (1 second, 809 milliseconds)
[info] - SPARK-31882: Link URL for Stage DAGs should not depend on paged table. (604 milliseconds)
[info] - SPARK-31886: Color barrier execution mode RDD correctly (252 milliseconds)
[info] - Search text for paged tables should not be saved (1 second, 309 milliseconds)
[info] Run completed in 6 seconds, 116 milliseconds.
[info] Total number of tests run: 4
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[info] RocksDBBackendChromeUIHistoryServerSuite:
[info] - ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase) (1 second, 615 milliseconds)
[info] Run completed in 5 seconds, 130 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 27 s, completed 2023-9-14 11:29:27

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang marked this pull request as draft September 13, 2023 11:29
@github-actions github-actions bot added the BUILD label Sep 13, 2023
@LuciferYang
Copy link
Contributor Author

wait SPARK-45150 fix first

@LuciferYang
Copy link
Contributor Author

will update pr description later

@srowen
Copy link
Member

srowen commented Sep 13, 2023

Looks OK if tests pass

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Sep 14, 2023

client INVALID_CURSOR.DISCONNECTED error is retried when other RPC preempts this one is a known very unstable test, Do we need to wait for it to be fixed before merging?

#42560 (review)

@LuciferYang LuciferYang marked this pull request as ready for review September 15, 2023 02:06
@LuciferYang
Copy link
Contributor Author

All test passed, could we merge this one? @srowen

@srowen srowen closed this in c1c5869 Sep 18, 2023
@srowen
Copy link
Member

srowen commented Sep 18, 2023

Merged to master

@LuciferYang
Copy link
Contributor Author

Thanks @srowen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants