[SPARK-44640][PYTHON][FOLLOW-UP] Update UDTF error messages to include method name #42726
+52
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ueshin |
ueshin
reviewed
Aug 29, 2023
| @@ -770,6 +770,7 @@ def verify_result(result): | |||
| message_parameters={ | |||
| "type_name": type(result).__name__, | |||
| "value": str(result), | |||
| "func": f.__name__, | |||
There was a problem hiding this comment.
I guess we should do the same thing for UDTF_RETURN_SCHEMA_MISMATCH or other error classes if possible?
There was a problem hiding this comment.
Good point! I will update the other places.
allisonwang-db
changed the title
ueshin
approved these changes
Aug 30, 2023
HyukjinKwon
approved these changes
Aug 30, 2023
|
@allisonwang-db the failure seems related |
|
We need this PR in branch-3.5 as well. |
|
Thanks! merging to master/ |
|
@allisonwang-db There is a conflict with 3.5. Could you help fix it and submit another PR? Thanks. |
allisonwang-db
added a commit
to allisonwang-db/spark
that referenced
this pull request
Sep 6, 2023
…e method name This PR is a follow-up for SPARK-44640 to make the error message of a few UDTF errors more informative by including the method name in the error message (`eval` or `terminate`). To improve error messages. No Existing tests. No Closes apache#42726 from allisonwang-db/SPARK-44640-follow-up. Authored-by: allisonwang-db <[email protected]> Signed-off-by: Takuya UESHIN <[email protected]> (cherry picked from commit 3e22c86) Signed-off-by: allisonwang-db <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up for SPARK-44640 to make the error message of a few UDTF errors more informative by including the method name in the error message (
evalorterminate).Why are the changes needed?
To improve error messages.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No