Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44376][BUILD] Fix maven build using scala 2.13 and Java 11 or later #41943

Closed
wants to merge 3 commits into from
Closed

[SPARK-44376][BUILD] Fix maven build using scala 2.13 and Java 11 or later #41943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de083b9
Drop hard coded -target value
eejbyfeldt Jul 11, 2023
7e9ca2f
Use the java.version property
eejbyfeldt Jul 12, 2023
d5b9d4f
Add java profiles with activations
eejbyfeldt Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2908,7 +2908,7 @@
<arg>-deprecation</arg>
<arg>-feature</arg>
<arg>-explaintypes</arg>
<arg>-target:jvm-1.8</arg>
eejbyfeldt marked this conversation as resolved.
Show resolved Hide resolved
<arg>-target:${java.version}</arg>
<arg>-Xfatal-warnings</arg>
<arg>-Ywarn-unused:imports</arg>
<arg>-P:silencer:globalFilters=.*deprecated.*</arg>
Expand Down Expand Up @@ -3475,6 +3475,36 @@

<profiles>

<profile>
<id>java-8</id>
<activation>
<jdk>1.8</jdk>
</activation>
<properties>
<java.version>1.8</java.version>
</properties>
</profile>

<profile>
<id>java-11</id>
<activation>
<jdk>11</jdk>
</activation>
<properties>
<java.version>11</java.version>
</properties>
</profile>

<profile>
<id>java-17</id>
<activation>
<jdk>17</jdk>
</activation>
<properties>
<java.version>17</java.version>
</properties>
</profile>

<!--
This profile is enabled automatically by the sbt build. It changes the scope for shaded
dependencies, since we don't shade it in the artifacts generated by the sbt build.
Expand Down Expand Up @@ -3619,7 +3649,7 @@
<arg>-deprecation</arg>
<arg>-feature</arg>
<arg>-explaintypes</arg>
<arg>-target:jvm-1.8</arg>
<arg>-target:${java.version}</arg>
<arg>-Wconf:cat=deprecation:wv,any:e</arg>
<arg>-Wunused:imports</arg>
<!--
Expand Down