-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-43880][BUILD] Organize hadoop-cloud
in standard maven project structure
#41380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
May 30, 2023
LuciferYang
reviewed
May 30, 2023
LuciferYang
approved these changes
May 30, 2023
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
…t structure ### What changes were proposed in this pull request? Since Spark does not support Hadoop2, we can merge the hadoop3-specific code into the standard maven project folders, which simplifies the `hadoop-cloud/pom.xml` I also checked and remove the unnecessary Hadoop related dependencies exclusions in `hadoop-cloud/pom.xml`. ### Why are the changes needed? Simplify Maven configuration files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Compare the dependency resolution, no change before and after this change. ``` build/mvn clean install -DskipTests -pl :spark-hadoop-cloud_2.13 -am -Phadoop-3,hadoop-cloud build/mvn dependency:list -pl :spark-hadoop-cloud_2.13 -am -Phadoop-3,hadoop-cloud ``` ``` [INFO] --------------< org.apache.spark:spark-hadoop-cloud_2.13 >-------------- [INFO] Building Spark Project Hadoop Cloud Integration 3.5.0-SNAPSHOT [13/13] [INFO] from hadoop-cloud/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- maven-dependency-plugin:3.5.0:list (default-cli) spark-hadoop-cloud_2.13 --- [INFO] [INFO] The following files have been resolved: [INFO] org.apache.orc:orc-core:jar:shaded-protobuf:1.8.3:compile [INFO] org.apache.orc:orc-shims:jar:1.8.3:compile [INFO] io.airlift:aircompressor:jar:0.21:compile [INFO] org.jetbrains:annotations:jar:17.0.0:compile [INFO] org.threeten:threeten-extra:jar:1.7.1:compile [INFO] org.apache.orc:orc-mapreduce:jar:shaded-protobuf:1.8.3:compile [INFO] org.apache.hive:hive-storage-api:jar:2.8.1:compile [INFO] org.apache.parquet:parquet-column:jar:1.13.1:compile [INFO] org.apache.parquet:parquet-common:jar:1.13.1:compile [INFO] org.apache.parquet:parquet-encoding:jar:1.13.1:compile [INFO] org.apache.yetus:audience-annotations:jar:0.13.0:compile [INFO] org.apache.parquet:parquet-hadoop:jar:1.13.1:compile [INFO] org.apache.parquet:parquet-format-structures:jar:1.13.1:compile [INFO] org.apache.parquet:parquet-jackson:jar:1.13.1:runtime [INFO] org.apache.avro:avro:jar:1.11.1:compile [INFO] org.apache.avro:avro-mapred:jar:1.11.1:compile [INFO] org.apache.avro:avro-ipc:jar:1.11.1:compile [INFO] org.tukaani:xz:jar:1.9:compile [INFO] javax.activation:activation:jar:1.1.1:compile [INFO] org.apache.curator:curator-recipes:jar:2.13.0:compile [INFO] org.apache.curator:curator-framework:jar:2.13.0:compile [INFO] org.apache.curator:curator-client:jar:2.13.0:compile [INFO] org.apache.zookeeper:zookeeper:jar:3.6.3:compile [INFO] org.apache.zookeeper:zookeeper-jute:jar:3.6.3:compile [INFO] commons-codec:commons-codec:jar:1.15:compile [INFO] org.apache.commons:commons-compress:jar:1.23.0:compile [INFO] org.apache.commons:commons-lang3:jar:3.12.0:compile [INFO] com.google.code.findbugs:jsr305:jar:3.0.0:runtime [INFO] org.slf4j:slf4j-api:jar:2.0.7:compile [INFO] org.xerial.snappy:snappy-java:jar:1.1.10.0:compile [INFO] com.github.luben:zstd-jni:jar:1.5.5-3:compile [INFO] org.apache.hadoop:hadoop-client-runtime:jar:3.3.5:compile [INFO] commons-logging:commons-logging:jar:1.1.3:compile [INFO] org.apache.hadoop:hadoop-aws:jar:3.3.5:compile [INFO] com.amazonaws:aws-java-sdk-bundle:jar:1.12.316:compile [INFO] org.wildfly.openssl:wildfly-openssl:jar:1.1.3.Final:compile [INFO] com.google.cloud.bigdataoss:gcs-connector:jar:shaded:hadoop3-2.2.14:compile [INFO] joda-time:joda-time:jar:2.12.5:compile [INFO] com.fasterxml.jackson.core:jackson-databind:jar:2.15.1:compile [INFO] com.fasterxml.jackson.core:jackson-core:jar:2.15.1:compile [INFO] com.fasterxml.jackson.core:jackson-annotations:jar:2.15.1:compile [INFO] com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.15.1:compile [INFO] org.apache.httpcomponents:httpclient:jar:4.5.14:compile [INFO] org.apache.httpcomponents:httpcore:jar:4.4.16:compile [INFO] org.apache.hadoop:hadoop-azure:jar:3.3.5:compile [INFO] com.microsoft.azure:azure-storage:jar:7.0.1:compile [INFO] com.microsoft.azure:azure-keyvault-core:jar:1.0.0:compile [INFO] org.apache.hadoop.thirdparty:hadoop-shaded-guava:jar:1.1.1:compile [INFO] org.apache.hadoop:hadoop-cloud-storage:jar:3.3.5:compile [INFO] org.apache.hadoop:hadoop-annotations:jar:3.3.5:compile [INFO] org.apache.hadoop:hadoop-aliyun:jar:3.3.5:compile [INFO] com.aliyun.oss:aliyun-sdk-oss:jar:3.13.0:compile [INFO] org.jdom:jdom2:jar:2.0.6:compile [INFO] com.aliyun:aliyun-java-sdk-core:jar:4.5.10:compile [INFO] org.ini4j:ini4j:jar:0.5.4:compile [INFO] io.opentracing:opentracing-api:jar:0.33.0:compile [INFO] io.opentracing:opentracing-util:jar:0.33.0:compile [INFO] io.opentracing:opentracing-noop:jar:0.33.0:compile [INFO] com.aliyun:aliyun-java-sdk-ram:jar:3.1.0:compile [INFO] com.aliyun:aliyun-java-sdk-kms:jar:2.11.0:compile [INFO] org.codehaus.jettison:jettison:jar:1.5.3:compile [INFO] org.apache.hadoop:hadoop-azure-datalake:jar:3.3.5:compile [INFO] com.microsoft.azure:azure-data-lake-store-sdk:jar:2.3.9:compile [INFO] org.eclipse.jetty:jetty-util:jar:9.4.51.v20230217:compile [INFO] org.eclipse.jetty:jetty-util-ajax:jar:9.4.51.v20230217:compile [INFO] org.spark-project.spark:unused:jar:1.0.0:compile [INFO] [INFO] ------------------------------------------------------------------------ ``` Closes apache#41380 from pan3793/SPARK-43880. Authored-by: Cheng Pan <[email protected]> Signed-off-by: yangjie01 <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 4, 2023
### What changes were proposed in this pull request? This PR aims to downgrade the Apache Hadoop dependency to 3.3.4 in `Apache Spark 3.5` in order to prevent any regression from `Apache Spark 3.4.x`. In other words, although `Apache Spark 3.5.x` will lose many bug fixes of Apache Hadoop 3.3.5 and 3.3.6, it will be in the same situation with `Apache Spark 3.4.x`. - SPARK-44197 Upgrade Hadoop to 3.3.6 (#41744) - SPARK-42913 Upgrade Hadoop to 3.3.5 (#39124) - SPARK-43448 Remove dummy dependency `hadoop-openstack` (#41133) On top of reverting SPARK-44197 and SPARK-42913, this PR has additional dependency exclusion change due to the following. - SPARK-43880 Organize `hadoop-cloud` in standard maven project structure (#41380) ### Why are the changes needed? There is a community report on S3A committer performance regression. Although it's one liner fix, there is no available Hadoop release with that fix at this time. - HADOOP-18757: Bump corePoolSize of HadoopThreadPoolExecutor in s3a committer (apache/hadoop#5706) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes #42345 from dongjoon-hyun/SPARK-44678. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since Spark does not support Hadoop2, we can merge the hadoop3-specific code into the standard maven project folders, which simplifies the
hadoop-cloud/pom.xml
I also checked and remove the unnecessary Hadoop related dependencies exclusions in
hadoop-cloud/pom.xml
.Why are the changes needed?
Simplify Maven configuration files.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Compare the dependency resolution, no change before and after this change.