-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-4599] [Build] [SQL] add hive profile in root pom #3450
Conversation
Test build #23834 has started for PR 3450 at commit
|
@@ -1394,7 +1394,7 @@ | |||
</dependencies> | |||
</profile> | |||
<profile> | |||
<id>hive-thriftserver</id> | |||
<id>hive</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this? there are already profiles covering activation of Hive itself below; this profile is supposed to be about thriftserver and is so named.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have hive-thriftserver always included when we have -Phive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases we want to build one but not the other. For instance Scala 2.11 does not yet support the thirftserver due to a dependency conflict.
Test build #23834 has finished for PR 3450 at commit
|
Test PASSed. |
We don't want to always build the thriftserver when hive support is enabled. Please see my e-mail to the dev list for more details. |
Thanks for the explanation, I'm closing it. |
This is what it was after #2685 , but seems reset by #3159