Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4599] [Build] [SQL] add hive profile in root pom #3450

Closed
wants to merge 1 commit into from

Conversation

adrian-wang
Copy link
Contributor

This is what it was after #2685 , but seems reset by #3159

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23834 has started for PR 3450 at commit cbb2d33.

  • This patch merges cleanly.

@@ -1394,7 +1394,7 @@
</dependencies>
</profile>
<profile>
<id>hive-thriftserver</id>
<id>hive</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this? there are already profiles covering activation of Hive itself below; this profile is supposed to be about thriftserver and is so named.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have hive-thriftserver always included when we have -Phive

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases we want to build one but not the other. For instance Scala 2.11 does not yet support the thirftserver due to a dependency conflict.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23834 has finished for PR 3450 at commit cbb2d33.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23834/
Test PASSed.

@pwendell
Copy link
Contributor

We don't want to always build the thriftserver when hive support is enabled. Please see my e-mail to the dev list for more details.

@adrian-wang
Copy link
Contributor Author

Thanks for the explanation, I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants