Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[SPARK-35253][SPARK-35398][SQL][BUILD] Bump up the janino version to v3.1.4" #33302

Closed
wants to merge 4 commits into from
Closed

Revert "[SPARK-35253][SPARK-35398][SQL][BUILD] Bump up the janino version to v3.1.4" #33302

wants to merge 4 commits into from

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

This PR reverts #32455 and its followup #32536 , because the new janino version has a bug that is not fixed yet: janino-compiler/janino#148

Why are the changes needed?

avoid regressions

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

@cloud-fan cloud-fan mentioned this pull request Jul 12, 2021
Closed
@cloud-fan
Copy link
Contributor Author

cc @maropu

@SparkQA
Copy link

SparkQA commented Jul 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45440/

@dongjoon-hyun
Copy link
Member

Could you resolve the conflicts, @cloud-fan ?

@SparkQA
Copy link

SparkQA commented Jul 12, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45440/

@SparkQA
Copy link

SparkQA commented Jul 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45443/

@SparkQA
Copy link

SparkQA commented Jul 12, 2021

Test build #140928 has finished for PR 33302 at commit 736e6df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 12, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45443/

@dongjoon-hyun dongjoon-hyun changed the title Revert "[SPARK-35253][SQL][BUILD] Bump up the janino version to v3.1.4" Revert "[SPARK-35253][SPARK-35398][SQL][BUILD] Bump up the janino version to v3.1.4" Jul 12, 2021
dongjoon-hyun
dongjoon-hyun approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SPARK-35398 has a different JIRA ID from SPARK-35253, I inevitably added it to the PR title.

@SparkQA
Copy link

SparkQA commented Jul 12, 2021

Test build #140931 has finished for PR 33302 at commit c730be7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Jul 12, 2021

late lgtm, thanks, @cloud-fan

LuciferYang
LuciferYang approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.2.

HyukjinKwon pushed a commit that referenced this pull request Jul 13, 2021
@cloud-fan @HyukjinKwon
Revert "[SPARK-35253][SPARK-35398][SQL][BUILD] Bump up the janino ver…
c1d8ccf 
…sion to v3.1.4"

### What changes were proposed in this pull request?

This PR reverts #32455 and its followup #32536 , because the new janino version has a bug that is not fixed yet: janino-compiler/janino#148

### Why are the changes needed?

avoid regressions

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests

Closes #33302 from cloud-fan/revert.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit ae6199a)
Signed-off-by: Hyukjin Kwon <[email protected]>
@LuciferYang
Copy link
Contributor

LuciferYang commented Jul 27, 2021 •
edited
Loading

@maropu It looks like janino is prepare to release 3.1.5

janino-compiler/janino@1a2d0b8

@singhpk234 singhpk234 mentioned this pull request Jul 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

@gengliangwang gengliangwang gengliangwang approved these changes

@LuciferYang LuciferYang LuciferYang approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
BUILD SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cloud-fan @SparkQA @dongjoon-hyun @maropu @HyukjinKwon @LuciferYang @viirya @gengliangwang