[SPARK-29199][INFRA] Add linters and license/dependency checkers to GitHub Action #25879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Test build #111107 has finished for PR 25879 at commit
|
|
Test build #111108 has finished for PR 25879 at commit
|
srowen
approved these changes
Sep 21, 2019
|
Thank you, @srowen . |
HyukjinKwon
reviewed
Sep 21, 2019
| - name: Scala | ||
| run: ./dev/lint-scala | ||
| - name: Java | ||
| run: ./dev/lint-java |
There was a problem hiding this comment.
FYI, using ./dev/sbt-checkstyle might speed up this linter but using mvn should be good enough.
|
LGTM too |
|
Thanks for the advice, @HyukjinKwon . |
|
Since |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 21, 2019
…itHub Action This PR aims to add linters and license/dependency checkers to GitHub Action. This excludes `lint-r` intentionally because https://github.com/actions/setup-r is not ready. We can add that later when it becomes available. This will help the PR reviews. No. See the GitHub Action result on this PR. Closes #25879 from dongjoon-hyun/SPARK-29199. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
scunniff
pushed a commit
to scunniff/nomad-spark
that referenced
this pull request
Nov 10, 2020
…itHub Action This PR aims to add linters and license/dependency checkers to GitHub Action. This excludes `lint-r` intentionally because https://github.com/actions/setup-r is not ready. We can add that later when it becomes available. This will help the PR reviews. No. See the GitHub Action result on this PR. Closes apache#25879 from dongjoon-hyun/SPARK-29199. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add linters and license/dependency checkers to GitHub Action. This excludes
lint-rintentionally because https://github.com/actions/setup-r is not ready. We can add that later when it becomes available.Why are the changes needed?
This will help the PR reviews.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
See the GitHub Action result on this PR.