[SPARK-29045][SQL][TESTS] Drop table to avoid test failure in SQLMetricsSuite #25752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @wangyum |
|
ok to test |
|
Test build #110453 has finished for PR 25752 at commit
|
wangyum
approved these changes
Sep 11, 2019
HyukjinKwon
approved these changes
Sep 12, 2019
|
Merged to master. |
|
Thank you, @LantaoJin , @wangyum , @HyukjinKwon . |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 14, 2019
…icsSuite ### What changes were proposed in this pull request? In method `SQLMetricsTestUtils.testMetricsDynamicPartition()`, there is a CREATE TABLE sentence without `withTable` block. It causes test failure if use same table name in other unit tests. ### Why are the changes needed? To avoid "table already exists" in tests. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exist UT Closes #25752 from LantaoJin/SPARK-29045. Authored-by: LantaoJin <[email protected]> Signed-off-by: Yuming Wang <[email protected]>
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
…icsSuite ### What changes were proposed in this pull request? In method `SQLMetricsTestUtils.testMetricsDynamicPartition()`, there is a CREATE TABLE sentence without `withTable` block. It causes test failure if use same table name in other unit tests. ### Why are the changes needed? To avoid "table already exists" in tests. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exist UT Closes apache#25752 from LantaoJin/SPARK-29045. Authored-by: LantaoJin <[email protected]> Signed-off-by: Yuming Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In method
SQLMetricsTestUtils.testMetricsDynamicPartition(), there is a CREATE TABLE sentence withoutwithTableblock. It causes test failure if use same table name in other unit tests.Why are the changes needed?
To avoid "table already exists" in tests.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist UT