Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17053: If all shards fail, fail the request despite shards.tolerant #2122

Closed
wants to merge 5 commits into from

Conversation

aparnasuresh85
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-17053

Description

Address a ClassCastException issue in the event exception in shard response is not of type org.apache.solr.common.SolrException,

Solution

Wrap the exception in shard response into org.apache.solr.common.SolrException and throw

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Tests checked in as part of previous PR here: #2102. Did not introduce additional testing with this PR as it is a minor change

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant