Add shareProcessNamespace flag to podOptions #735
Conversation
Boolean flag defaults unset, and is available in the CRD at `.spec.customSolrKubeOptions.podOptions.shareProcessNamespace`
| @@ -42,15 +42,12 @@ annotations: | |||
| # Allowed syntax is described at: https://artifacthub.io/docs/topics/annotations/helm/#example | |||
| artifacthub.io/changes: | | |||
| - kind: added | |||
| description: Addition 1 | |||
| description: SolrClouds now support namespace sharing among pod containers in a pod. | |||
There was a problem hiding this comment.
Every time I come back to this project after a lull, I have trouble deciding which chart should hold a given change-entry.
Hopefully I've picked correctly here - I picked the 'solr' chart because the newly-exposed option affects the Solr pods (and not the operator pod itself)
There was a problem hiding this comment.
Solr Operator, since that is the main chart (you can use the solr operator chart without using the solr chart, but not really the other way around). The Solr chart changeling is only used for changes relating to that helm chart.
|
This PR should allow us to close #716 |
| @@ -137,6 +137,10 @@ type PodOptions struct { | |||
| // +optional | |||
| ServiceAccountName string `json:"serviceAccountName,omitempty"` | |||
|
|
|||
| // Should process namespace sharing be enabled on created pods | |||
| // +optional | |||
| ShareProcessNamespace *bool `json:"shareProcessNamespace,omitempty"` | |||
There was a problem hiding this comment.
Since the default is false, this probably doesn't need to be a pointer. pointer is only used when we want to differentiate the default value of the variable and the default when users leave the field empty.
Boolean flag defaults unset, and is available in the CRD at
.spec.customSolrKubeOptions.podOptions.shareProcessNamespace