Fixing Rest config NPE & ZK Persistence Reconciling/Defaulting & Backup/Restore Volume mount #65
Conversation
| @@ -31,8 +31,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| BaseBackupRestorePath = "/var/solr-backup-restore" | |||
| TarredFile = "/var/solr-backup-restore/backup.tgz" | |||
| BaseBackupRestorePath = "/var/solr/solr-backup-restore" | |||
There was a problem hiding this comment.
This fixes permission problem when exec the EnsureDirectory function.
| @@ -3,6 +3,13 @@ kind: SolrCloud | |||
| metadata: | |||
| name: example | |||
| spec: | |||
| dataPvcSpec: | |||
There was a problem hiding this comment.
Need to have persistent PVCs for test_solrcloud so that when docker locally restarts, collections and replica data persists nicely, otherwise collections and shards will remain down.
sepulworld
force-pushed
the
bug/fixing_solrbackup_crd
branch
from
66c70eb to
fdfdeda
Compare
sepulworld
changed the title
Signed-off-by: Zane Williamson <[email protected]>
sepulworld
force-pushed
the
bug/fixing_solrbackup_crd
branch
from
fffb82c to
f48ce45
Compare
Also uses the `changed = true` tag so that the Solr object is updated with the default values. Signed-off-by: Houston Putman <[email protected]>
Signed-off-by: Houston Putman <[email protected]>
Making fixes and added a test.
|
Awesome! We good to go with this? |
Not yet, I commented in the thread above. When a user doesn't provide a persistence spec for ZK we go into an update loop. (This was working ok prior to your merged in changes). Let me see if I can find issue |
Signed-off-by: Houston Putman <[email protected]>
|
Ugh it's because my PR to the zk-operator hasn't been merged. I think I've fixed it though. I'll also test it out. |
Fixed empty zk persistence option. And logging.
HoustonPutman
changed the title
Tested out locally and works well now! I think we are good. Leave in the commented out code and add back when upstream change gets applied? |
|
Yep! That's why I linked the PR in the comment. It'll be easy to remove
now. Just need to add an upgrade note for a new minimum version of the
ZK-Operator.
…On Wed, Jan 8, 2020 at 4:00 PM Zane Williamson ***@***.***> wrote:
Ugh it's because my PR to the zk-operator hasn't been merged. I think I've
fixed it though. I'll also test it out.
Tested out locally and works well now! I think we are good. Leave in the
commented out code and add back when upstream change gets applied?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#65>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZYKJQEKXQCR54ODH3AFYDQ4Y5GTANCNFSM4KCHMKAQ>
.
|
Signed-off-by: Zane Williamson [email protected]
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.