Use global.imagePullSecrets at solr-operator helm chart #338 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j-coll , thanks for the contribution. This looks great! I think we are aiming to have a swift release of Could you rebase this off of main, change the target branch for this PR to main and also add a changelog entry? |
|
In the meantime if you need a quick fix, I would look at using serviceAccounts to store your imagePullSecret info, then use that service account for the Solr Operator and the Zookeeper Operator. |
|
Sure thing, I will rebase it. And thanks for service-account advice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to push to release-0.4 as it's just a minimal change (I'd love to see a 0.4.1). Please, let me know if the PR should be against main instead.