Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for Ingress TLS termination for SolrCloud. #293

Merged
merged 13 commits into from
Aug 5, 2021

Conversation

HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman commented Jul 20, 2021

Resolves #268

This gives the user to enable TLS Termination in the Ingress for all external Solr traffic.
Users then have the ability to limit what endpoints are available outside the cluster through hideNodes and hideCommon.

This cannot be used with useExternalAddress, as Solr cannot be listening on HTTP and make internal communication through HTTPS.

@HoustonPutman HoustonPutman requested a review from thelabdude July 21, 2021 20:20
Copy link
Contributor

@thelabdude thelabdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Docs are clear and concise.

@HoustonPutman HoustonPutman changed the title Add option for Ingress TLS termination for common endpoint. Add option for Ingress TLS termination for SolrCloud. Jul 21, 2021
@HoustonPutman
Copy link
Contributor Author

So it looks like Nginx does support tls-passthrough with different TLS options. So while the current PR does work, we will probably want to change a few things to support the ingress TLS termination with Solr TLS enabled.

@HoustonPutman HoustonPutman merged commit b13db1d into apache:main Aug 5, 2021
@HoustonPutman HoustonPutman deleted the ingress-tls branch August 5, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying the name of a TLS secret for the Ingress to support TLS termination at the Ingress
2 participants