Add terminationGracePeriod option, and use it when killing Solr. #226
Conversation
| ... | ||
| customSolrKubeOptions: | ||
| podOptions: | ||
| terminationGracePeriodSeconds: 120 |
There was a problem hiding this comment.
So this still means that administrators need to set this manually, rather than automatically picking up what is derived from the k8s source of truth?
There was a problem hiding this comment.
This is a setting that users can set on pods, we merely forward this information to the pod. There is no k8s source of truth other than the value that each pod has. The default, set by the Solr Operator is 60 seconds.
Also I think the default value (for the pod) is different based on the kubernetes distribution you use, but we shouldn't be relying on a default that has nothing to do with Solr.
There was a problem hiding this comment.
If a user issues a command k delete --grace-period=5s than that will override our configured setting. We should figure out how to do our best to react to the new directives.
There was a problem hiding this comment.
That command is kind of similar to kill -9. I'm not sure there is a way to protect against that. Is there a way to figure out what grace period is given when your pod is trying to be deleted? Pod.spec is static, so the Pod.spec.terminationGracePeriodSeconds, provided when the pod is created, will never change. If a user runs k delete --grace-period=5s, it will stay at 60 and not change to 5.
Most of the time, Pods are going to be deleted by Kubernetes (the statefulset controller) or the solrcloud controller, during managed upgrades. Neither of those use a different grace period, so the usage here is safe.
|
Please add a |
…apache#226) terminationGracePeriod used to be statically set to 10 seconds. Now it defaults to 30 seconds, but is configurable. SOLR_STOP_WAIT will be set to the terminationGracePeriod, minus a few seconds, so that kubernetes and Solr are on the same page.
Fixes #227
This will use the
terminationGracePeriod, minus a few seconds, and give that to Solr as theSOLR_STOP_WAITvalue.That way Solr and Kubernetes are on the same page as to how much time to wait before forcefully stopping Solr.
terminationGracePeriodused to be statically set to 10 seconds. Now it defaults to 30 seconds, but is configurable.