Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same portName as targetPort in service and fix Status bugs. #145

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Use same portName as targetPort in service and fix Status bugs. #145

merged 1 commit into from
Oct 7, 2020

Conversation

HoustonPutman
Copy link
Contributor

Issue number of the reported bug or feature request: Fixes #141, #142

Describe your changes
Two issues are fixed here:

  1. The portName and targetPort for SolrCloud services have been changed to have the same name. This fixes issues with certain cloud providers that have bugs with regard to that. (The Cloud status has incorrect values for common and node addresses. #141)
  2. The SolrCloud status object had multiple issues with the urls it displayed for users to connect with. (Cannot connect to ServiceIP service for either SolrCloud or SolrPrometheusExporter. #142)

Testing performed
Unit tests have been modified to ensure that these values are now correct in the future.

@HoustonPutman
Fix service portName and status URL bugs. (apache#145)
e2fb893 
- The portName in services must be changed to match the pod portName used
in target port. This is because of bugs in various Kubernetes providers.

- Fix bugs in addresses in SolrCloud Status, both node and common.

Signed-off-by: Houston Putman <[email protected]>
bsankara
bsankara approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@bsankara bsankara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this @HoustonPutman

@bsankara bsankara merged commit 507e0c9 into apache:master Oct 7, 2020
@HoustonPutman HoustonPutman deleted the port-names branch October 7, 2020 15:57
thelabdude pushed a commit to thelabdude/solr-operator that referenced this pull request Oct 9, 2020
@HoustonPutman @thelabdude
Fix service portName and status URL bugs. (apache#145)
b47487b 
- The portName in services must be changed to match the pod portName used
in target port. This is because of bugs in various Kubernetes providers.

- Fix bugs in addresses in SolrCloud Status, both node and common.

Signed-off-by: Houston Putman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsankara bsankara bsankara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Cloud status has incorrect values for common and node addresses.
2 participants
@HoustonPutman @bsankara