Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5795 #5797

Merged
merged 6 commits into from
Nov 5, 2020
Merged

Fix issue #5795 #5797

merged 6 commits into from
Nov 5, 2020

Conversation

simonlei
Copy link
Contributor

@simonlei simonlei commented Nov 5, 2020

Fix the issue: nutz plugin throw NPE at afterMethod, cause traceid keep unchange for the thread

Fix

Fix the issue: nutz plugin throw NPE at afterMethod, cause traceid keep unchange for the thread
@kezhenxu94 kezhenxu94 added agent Language agent related. bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Nov 5, 2020
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, please fix codestyle(you can run ./mvnw checkstyle:check locally to verify), and update the CHANGES.md

@simonlei
Copy link
Contributor Author

simonlei commented Nov 5, 2020

Thanks for contributing, please fix codestyle(you can run ./mvnw checkstyle:check locally to verify), and update the CHANGES.md

Thanks for the reply. Fixed codestyle and update the CHANGES.md.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #5797 into master will decrease coverage by 52.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #5797       +/-   ##
============================================
- Coverage     52.74%   0.00%   -52.75%     
============================================
  Files           892     166      -726     
  Lines         22406    3991    -18415     
  Branches       2141     458     -1683     
============================================
- Hits          11819       0    -11819     
+ Misses         9637    3991     -5646     
+ Partials        950       0      -950     
Impacted Files Coverage Δ Complexity Δ
...ywalking/apm/agent/core/logging/core/LogLevel.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ywalking/apm/agent/core/plugin/EnhanceContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...ywalking/apm/agent/core/profile/ProfileStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/context/SW8CarrierItem.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/logging/core/LogOutput.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/plugin/match/NameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...alking/apm/agent/core/context/CarrierItemHead.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...alking/apm/agent/core/jvm/gc/ParallelGCModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...lking/apm/agent/core/remote/GRPCChannelStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 876 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32caab...4ea66c5. Read the comment docs.

wu-sheng
wu-sheng previously approved these changes Nov 5, 2020
@wu-sheng wu-sheng added this to the 8.3.0 milestone Nov 5, 2020
wu-sheng
wu-sheng previously approved these changes Nov 5, 2020
kezhenxu94
kezhenxu94 previously approved these changes Nov 5, 2020
@kezhenxu94 kezhenxu94 dismissed stale reviews from wu-sheng and themself via 4ea66c5 November 5, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nutz plugin throw NPE at afterMethod, cause traceid keep unchange for the thread
3 participants