fix license header normalizer

[xiaoyawei]

Why do we need this fix?

As we are using license-eyes to check license header in our open-sourced projects, we notice that it can help detect
unexpected changes in the license header, except the copyright line. In my opinion, it's also necessary to protect the copyright line from unintentional changes.

How was this issue introduced?

#46 introduced this line processor to ignore copyright line, mostly for the purpose of dependency resolution. However, in #107 starts using Google's license check for this purpose, and this line processor only works to ignore copyright line when checking / fixing license header.

Reviewer

@kezhenxu94

[tisonkun]

This commit causes a previously passed CI to fail. You may re-check the diff: https://github.com/tisonkun/failpoints/actions/runs/3342840329/jobs/5535474781

[xiaoyawei]

@tisonkun your CI failures look reasonable to me: its copyright line in license header does not match the specs in https://github.com/tisonkun/failpoints/blob/main/tools/ci/licenserc.yml

[kezhenxu94]

I knew this was a breaking change, but it breaks something that was wrongly configured, and the previous successful CI should have been failed.

In your case, using spdx-id whose content has variables should be substituted, so you might need to provide copyright-owner, I know that would also fail because of a bug #143, the variables are not substituted previously.

[kezhenxu94]

@tisonkun with #143 and the following patch to your repo, CI should pass

diff --git a/tools/ci/licenserc.yml b/tools/ci/licenserc.yml
index 7122e11..2c56a5d 100644
--- a/tools/ci/licenserc.yml
+++ b/tools/ci/licenserc.yml
@@ -15,6 +15,7 @@
 header:
   license:
     spdx-id: Apache-2.0
+    copyright-owner: tison <[email protected]>
   paths:
     - '**/*.java'
     - '**/*.yml'

Let me know if that fix makes sense to you.

[tisonkun]

@kezhenxu94 fair enough. Apply and fix the issue :)