-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release, versioning and continous integration #585
Comments
Hi @nudles , is it possible to access the machine running jenkins? |
I have studied how fastai release process works, and semantic versioning and etc. In my opinion, this topic involves 2 roles:
The automation should do If this approach is ok, then we need to add automation part. |
Hi @nudles , how release is done currently? is this flag "TRAVIS_SECURE_ENV_VARS" (tool/travis/build.sh line 41) used? if [[ "$TRAVIS_SECURE_ENV_VARS" == "false" ]];
# install and run unittest
then
echo "no uploading if ANACONDA_UPLOAD_TOKEN not set"
else
# turn off debug to hide the token in travis log
set +x
# upload the package onto anaconda cloud
anaconda -t $ANACONDA_UPLOAD_TOKEN upload -u $USER -l main $CONDA_BLD_PATH/$OS/singa-*.tar.bz2 --force
fi |
Yes. Currently, we use Travis to build CPU package and Jenkins to build GPU package. |
Currently, how is the "release" build triggered or how is the Env Var TRAVIS_SECURE_ENV_VARS set? for travis is it done by web UI? https://blog.travis-ci.com/2017-08-24-trigger-custom-build |
The travis for apache/singa does not upload the package because the variable is not set. |
Hi @nudles , could you kindly advise if this PR caters this issue? |
|
All of this can be easily done with Github Actions. The CI in Github can be configured to monitor a given branch. There are many actions available for use that manage the version tags, create docker containers and so on. |
Hi @moazreyad , thank you for the advice, I will study how github actions works. |
Regarding 1, after comparing other framework, like tf.
For torch, similarily:
By right, simply speaking, |
Since everything here is public, we do not have an internal testing phase.
I suggest skipping alpha and beta versions.
…On Fri, Mar 13, 2020 at 11:03 AM Shicong ***@***.***> wrote:
1. if the building of the conda package fails, we need to delete the
newly updated tag? Alternatively, we may need to consider a pre-release
version like 3.0.0-alpha0. Then, we need to parse the version ID with
-alphaX.
2. both the CMake and Conda building scripts need to parse the version
from the git tag.
3. The CI needs to monitor both the dev and master branch. Only when
the tag of the master branch changes, it uploads the pacakges (and docker
images?).
Regarding 1, after comparing other framework, like tf.
- For major release, they have alpha and beta, then followed by rc,
release candidate.
- And for minor, pre release starts from rc.
- While patch will be release directly.
For torch, similarily:
- major starts from alpha, followed by rc
- minor starts from rc
- patch is release directly.
By right, simply speaking, alpha is first phase of testing internally.
beta is testing publicly. rc is almost like stable release unless serious
bug is discovered.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#585 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA47DRZC7TN6ADQQCSJLYSDRHGO6DANCNFSM4KNSRRIQ>
.
|
Is it possible to build the website via Github Action? We need the following steps
|
The text was updated successfully, but these errors were encountered: