#1172, start SkyWalking configurable

sharding-core/src/main/java/io/shardingsphere/core/constant/properties/ShardingPropertiesConstant.java

@@ -68,6 +68,8 @@ public enum ShardingPropertiesConstant {
 
     PROXY_TRANSACTION_ENABLED("proxy.transaction.enabled", String.valueOf(Boolean.FALSE), boolean.class),
 
+    PROXY_OPENTRACING_ENABLED("proxy.opentracing.enabled", String.valueOf(Boolean.FALSE), boolean.class),
+
     PROXY_BACKEND_USE_NIO("proxy.backend.use.nio", String.valueOf(Boolean.FALSE), boolean.class),
 
     PROXY_BACKEND_MAX_CONNECTIONS("proxy.backend.max.connections", String.valueOf(8), int.class),

sharding-opentracing/src/main/java/io/shardingsphere/opentracing/ShardingTracer.java

@@ -33,7 +33,7 @@
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public final class ShardingTracer {
 
-    private static final String OPENTRACING_TRACER_CLASS_NAME = "shardingsphere.opentracing.tracer.class";
+    private static final String OPENTRACING_TRACER_CLASS_NAME = "io.shardingsphere.opentracing.tracer.class";
 
     /**
      * Initialize sharding tracer.

sharding-proxy/pom.xml

@@ -79,16 +79,6 @@
             <groupId>commons-codec</groupId>
             <artifactId>commons-codec</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.apache.skywalking</groupId>
-            <artifactId>apm-toolkit-opentracing</artifactId>
-            <version>5.0.0-RC2</version>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.skywalking</groupId>
-            <artifactId>apm-collector-core</artifactId>
-            <version>5.0.0-RC2</version>
-        </dependency>
     </dependencies>
 
     <build>

sharding-proxy/src/main/java/io/shardingsphere/proxy/Bootstrap.java

@@ -31,7 +31,6 @@
 import io.shardingsphere.proxy.listener.ProxyListenerRegister;
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
-import org.apache.skywalking.apm.toolkit.opentracing.SkywalkingTracer;
 
 import java.io.IOException;
 import java.util.HashMap;
@@ -58,7 +57,6 @@ public final class Bootstrap {
      * @throws IOException IO exception
      */
     public static void main(final String[] args) throws InterruptedException, IOException {
-        ShardingTracer.init(new SkywalkingTracer());
         ProxyConfiguration proxyConfig = new ProxyYamlConfigurationLoader().load();
         int port = getPort(args);
         new ProxyListenerRegister().register();
@@ -83,6 +81,7 @@ private static int getPort(final String[] args) {
     private static void startWithoutRegistryCenter(
             final ProxyYamlServerConfiguration serverConfig, final Map<String, ProxyYamlRuleConfiguration> ruleConfigs, final int port) throws InterruptedException {
         ProxyContext.getInstance().init(getYamlServerConfiguration(serverConfig), getSchemaDataSourceMap(ruleConfigs), getRuleConfiguration(ruleConfigs));
+        initOpenTracing();
         new ShardingProxy().start(port);
     }
 
@@ -94,10 +93,17 @@ private static void startWithRegistryCenter(
             }
             ProxyContext.getInstance().init(orchestrationFacade.getConfigService().loadYamlServerConfiguration(), 
                     orchestrationFacade.getConfigService().loadProxyDataSources(), orchestrationFacade.getConfigService().loadProxyConfiguration());
+            initOpenTracing();
             new ShardingProxy().start(port);
         }
     }
 
+    private static void initOpenTracing() {
+        if (ProxyContext.getInstance().isOpenTracingEnable()) {
+            ShardingTracer.init();
+        }
+    }
+
     private static YamlServerConfiguration getYamlServerConfiguration(final ProxyYamlServerConfiguration serverConfig) {
         YamlServerConfiguration result = new YamlServerConfiguration();
         result.setProxyAuthority(serverConfig.getProxyAuthority());

sharding-proxy/src/main/java/io/shardingsphere/proxy/config/ProxyContext.java

@@ -71,6 +71,8 @@ public final class ProxyContext {
 
     private TransactionType transactionType;
 
+    private boolean openTracingEnable;
+
     private BackendNIOConfiguration backendNIOConfig;
 
     private boolean isCircuitBreak;
@@ -113,6 +115,7 @@ private void initServerConfiguration(final YamlServerConfiguration serverConfig)
         maxConnectionsSizePerQuery = shardingProperties.getValue(ShardingPropertiesConstant.MAX_CONNECTIONS_SIZE_PER_QUERY);
         // TODO just config proxy.transaction.enable here, in future(3.1.0)
         transactionType = shardingProperties.<Boolean>getValue(ShardingPropertiesConstant.PROXY_TRANSACTION_ENABLED) ? TransactionType.XA : TransactionType.LOCAL;
+        openTracingEnable = shardingProperties.<Boolean>getValue(ShardingPropertiesConstant.PROXY_OPENTRACING_ENABLED);
         showSQL = shardingProperties.getValue(ShardingPropertiesConstant.SQL_SHOW);
         acceptorSize = shardingProperties.getValue(ShardingPropertiesConstant.ACCEPTOR_SIZE);
         executorSize = shardingProperties.getValue(ShardingPropertiesConstant.EXECUTOR_SIZE);

sharding-proxy/src/main/resources/conf/server.yaml

@@ -20,4 +20,5 @@
 #  acceptor.size: 16  # The default value is available processors count * 2.
 #  executor.size: 16  # Infinite by default.
 #  proxy.transaction.enabled: false
+#  proxy.opentracing.enabled: false
 #  sql.show: false