-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firebird support to testcontainers database type #33782
Comments
I tested the firebird-testcontainers library from this repository and found that it works with ODS versions up to 12.0, which corresponds to Firebird 3.0. However, it is incompatible with newer ODS versions, such as 13.1, used in Firebird 5.0, and produces the following error:
This incompatibility arises because starting with Firebird 3.0, the ODS structure underwent significant changes, and Firebird 5.0 introduced a new ODS version (13.0). Conclusion Additional Information
|
* Added support to TestContainers JDBC URL of Firebird (/issues/33782) * apply Spotless formatting * correct naming * Spotless formatting after (mvnw spotless:apply -Pcheck)
I think we also need to update the documentation at https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/optional-plugins/testcontainers/. Maybe reopen this issue or I can create a new one. |
|
At the moment, we are working on a major task, which is why we cannot fully delve into studying various issues that also concern us. Currently, I am just exploring the ShardingSphere project, looking for new features to add and implement, and gradually working on these topics. We hope to complete this task successfully by the New Year, and once it is accomplished, we will be able to fully focus on ShardingSphere. I will be able to finish everything I have planned, and your comment will be very helpful. Thank you for that! |
@strongduanmu I apologize, I made a mistake and used Ref instead of Fixes, which prevented the ticket from being closed automatically. Could you please close it? We will continue working on this topic in new issues. |
@makssent This was my mistake, I modified the Fixes, I close it now. 😂 |
Feature Request
For English only, other languages will not be accepted.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Is your feature request related to a problem?
Related to #33699.
Describe the feature you would like.
Firebird has support for testcontainers (https://github.com/FirebirdSQL/firebird-testcontainers-java), but I can't find this module in the official documentation (https://java.testcontainers.org/modules/databases/jdbc/).
We will investigate this issue later, maybe i will close this issue if the module is out of date or cannot be used in ShardingSphere.
The text was updated successfully, but these errors were encountered: