-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Flink] Fix NPE when get null row from upstream transform #8469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passes. Thanks @litiliu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test case in
Line 28 in adb656e
public class TestFilterRowKindIT extends TestSuiteBase { |
...c/test/java/org/apache/seatunnel/engine/e2e/console/FakeSourceToFilterToCopyToConsoleIT.java
Outdated
Show resolved
Hide resolved
...orms-v2-e2e-part-1/src/test/java/org/apache/seatunnel/e2e/transform/TestFilterRowKindIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passes.
Purpose of this pull request
This close #8468
This PR adds a filter operator to filter the null rows generated by the transform plugins. It's easier than adding the null check in every transform plugin.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.