Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][API] support metrics interface in rest v2 #8312

Merged
merged 8 commits into from
Dec 25, 2024

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

current, metrics api is only support in rest v1, add this into v2

Does this PR introduce any user-facing change?

How was this patch tested?

add new test and with exist tests

Check list

@liunaijie
Copy link
Member Author

cc @corgy-w as I can't add you into review list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @corgy-w

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liunaijie liunaijie merged commit bd89d84 into apache:dev Dec 25, 2024
5 checks passed
@liunaijie liunaijie deleted the improve/metrics_api branch December 25, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants