Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Jdbc] Support nvarchar in dm #8270

Merged
merged 3 commits into from
Dec 15, 2024
Merged

[Improve][Jdbc] Support nvarchar in dm #8270

merged 3 commits into from
Dec 15, 2024

Conversation

dufeng1010
Copy link
Contributor

Purpose of this pull request

fix support nvarchar type in dm database

#8232

Does this PR introduce any user-facing change?

NO

Hisoka-X
Hisoka-X reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test case in

seatunnel/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbTypeConverterTest.java

Line 34 in caf37fc

public class DmdbTypeConverterTest {

@hailin0 hailin0 changed the title [Bug][Connector-jdbc]fix_support_nvarchar_in_dm [Improve][Jdbc]Support nvarchar in dm Dec 15, 2024
@hailin0 hailin0 changed the title [Improve][Jdbc]Support nvarchar in dm [Improve][Jdbc] Support nvarchar in dm Dec 15, 2024
@hailin0 hailin0 merged commit 2f1c54e into apache:dev Dec 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 jdbc reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dufeng1010 @hailin0 @Hisoka-X