Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Redis] Flush data when the time reaches checkpoint.interval #8198

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[Feature][Redis] Flush data when the time reaches checkpoint.interval #8198

merged 4 commits into from
Dec 10, 2024

Conversation

lm-ylj
Copy link
Contributor

@lm-ylj lm-ylj commented Dec 3, 2024

Purpose of this pull request

close #8174

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X Hisoka-X changed the title [Feature][Redis-Connector] Flush data when the time reaches checkpoint.interval [Feature][Redis] Flush data when the time reaches checkpoint.interval Dec 4, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 4, 2024

Thanks @lm-ylj ! Could you add a test case?

@lm-ylj
Copy link
Contributor Author

lm-ylj commented Dec 5, 2024

Thanks @lm-ylj ! Could you add a test case?

Ok, I will finish this later

@github-actions github-actions bot added the e2e label Dec 6, 2024
Merge branch 'dev' of https://github.com/apache/seatunnel into featur…
380df52 
…e-support-redis-write-in-real-time

# Conflicts:
#	seatunnel-e2e/seatunnel-connector-v2-e2e/connector-redis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisTestCaseTemplateIT.java
Hisoka-X
Hisoka-X approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lm-ylj !

@hailin0 hailin0 merged commit 2e24941 into apache:dev Dec 10, 2024
5 checks passed
zhangshenghang added a commit to zhangshenghang/data-integration that referenced this pull request Dec 12, 2024
@zhangshenghang
Revert "[Feature][Redis] Flush data when the time reaches checkpoint.…
9390b3a 
…interval (apache#8198)"

This reverts commit 2e24941.
@Hisoka-X
Copy link
Member

Hi @lm-ylj , we already reverted this PR by #8278. Because this PR broken our ci. Could you try re-raise a PR?

@lm-ylj
Copy link
Contributor Author

lm-ylj commented Dec 13, 2024

Hi @lm-ylj , we already reverted this PR by #8278. Because this PR broken our ci. Could you try re-raise a PR?

Sorry, I'll double check this test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 e2e redis reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Redis-Connector] Redis sink support write full data in real time
3 participants
@lm-ylj @Hisoka-X @hailin0