Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][dist]add shade check rule #8136

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Conversation

hawk9821
Copy link
Contributor

@hawk9821 hawk9821 commented Nov 25, 2024

Purpose of this pull request

Globally check that shade related classes are used correctly in project. Log format:

org.opentest4j.AssertionFailedError: guava shade is not up to code, need add prefix [org.apache.seatunnel.shade.]. 
E:\work\seatunnel\seatunnel-api\src\main\java\org\apache\seatunnel\api\table\type\MapType.java
com.google.common.base.Preconditions.checkArgument  [27]
com.google.common.base.Preconditions.checkNotNull  [28]
E:\work\seatunnel\seatunnel-core\seatunnel-spark-starter\seatunnel-spark-starter-common\src\main\java\org\apache\seatunnel\core\starter\spark\execution\SourceExecuteProcessor.java
com.google.common.collect.Lists  [20]
 ==> 
Expected :0
Actual   :2
<Click to see difference>

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hawk9821 hawk9821 force-pushed the import_shade_class branch 3 times, most recently from a894b64 to f2f9e07 Compare November 27, 2024 01:59
@github-actions github-actions bot added the CI&CD label Nov 27, 2024
Hisoka-X
Hisoka-X previously approved these changes Nov 29, 2024
@Hisoka-X
Copy link
Member

Please resolve conflicts.

@Hisoka-X Hisoka-X merged commit 51ef800 into apache:dev Nov 30, 2024
5 checks passed
@hawk9821 hawk9821 deleted the import_shade_class branch December 3, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants