-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][dist]add shade check rule #8136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44166cf
to
3e93447
Compare
Hisoka-X
reviewed
Nov 25, 2024
Hisoka-X
reviewed
Nov 25, 2024
seatunnel-dist/src/test/java/org/apache/seatunnel/ImportShadeClassCheck.java
Outdated
Show resolved
Hide resolved
seatunnel-dist/src/test/java/org/apache/seatunnel/ImportShadeClassCheck.java
Outdated
Show resolved
Hide resolved
a894b64
to
f2f9e07
Compare
796fef7
to
cb8120a
Compare
Hisoka-X
previously approved these changes
Nov 29, 2024
Please resolve conflicts. |
5e7c7af
to
4a9fa58
Compare
hailin0
approved these changes
Nov 30, 2024
Hisoka-X
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
approved
CI&CD
connectors-v2
core
SeaTunnel core module
e2e
format
reviewed
Spark
transform-v2
Zeta Rest API
Zeta
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Globally check that shade related classes are used correctly in project. Log format:
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.