[Improve][Zeta] Remove default jvm memory option #8068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
commented
Nov 15, 2024
| @@ -317,7 +320,9 @@ public static List<TestContainer> discoverTestContainers() { | |||
| .filter(container -> container.identifier().isTestInPR()) | |||
| .filter( | |||
| container -> { | |||
| if (testAllContainer) { | |||
| if (testAllContainer | |||
There was a problem hiding this comment.
also fix sometime test case can not find container error.
hailin0
approved these changes
Nov 15, 2024
Hisoka-X
force-pushed
the
remove-default-jvm-config
branch
from
8b4ee61 to
e70ec82
Compare
liunaijie
approved these changes
Nov 18, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Nov 18, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Remove default jvm memory option, let jvm set default xms/xmx by itself.
Does this PR introduce any user-facing change?
no
How was this patch tested?
exist test
Check list
New License Guide
release-note.